alamb commented on code in PR #5328:
URL: https://github.com/apache/arrow-rs/pull/5328#discussion_r1485569445
##########
arrow-schema/src/schema.rs:
##########
@@ -140,6 +140,15 @@ impl From<Fields> for SchemaBuilder {
}
}
+impl From<&Schema> for SchemaBuilder {
+ fn from(value: &Schema) -> Self {
+ Self {
+ fields: value.fields.to_vec(),
+ metadata: value.metadata.clone(),
+ }
Review Comment:
This could be slightly more concise 🤔
```suggestion
Self::from(value.clone())
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
