ritchie46 commented on code in PR #5383:
URL: https://github.com/apache/arrow-rs/pull/5383#discussion_r1485676362
##########
object_store/src/client/retry.rs:
##########
@@ -263,7 +262,7 @@ impl RetryExt for reqwest::RequestBuilder {
do_retry = true
} else if let Some(source) = e.source() {
if let Some(e) =
source.downcast_ref::<hyper::Error>() {
- if e.is_connect() || e.is_closed() ||
e.is_incomplete_message() {
+ if !(e.is_parse() || e.is_parse_status() ||
e.is_parse_too_large() || e.is_user() || e.is_canceled()) {
Review Comment:
> stalling
Right. So we call multiple ranges (e.g. columns) here:
https://github.com/pola-rs/polars/blob/81bd89cde7d5639e8567e9548e5529130bdd5c94/crates/polars-io/src/parquet/async_impl.rs#L66C9-L66C32
Where the semaphore logic is a generic utility here:
https://github.com/pola-rs/polars/blob/81bd89cde7d5639e8567e9548e5529130bdd5c94/crates/polars-io/src/pl_async.rs#L15
As I understand it the semaphore waits with a task until it has enough
permits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
