jackwener commented on code in PR #9154:
URL: https://github.com/apache/arrow-datafusion/pull/9154#discussion_r1486125136
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1184,13 +1204,15 @@ pub fn build_join_schema(
right_fields.clone()
}
};
+ //println!("total fields is {:?}", fields);
let func_dependencies = left.functional_dependencies().join(
right.functional_dependencies(),
join_type,
left_fields.len(),
);
let mut metadata = left.metadata().clone();
metadata.extend(right.metadata().clone());
+ // let schema =
DFSchema::new_with_metadata(change_redundant_column(fields), metadata)?;
Review Comment:
```suggestion
```
##########
datafusion/core/src/datasource/memory.rs:
##########
@@ -65,6 +65,10 @@ impl MemTable {
pub fn try_new(schema: SchemaRef, partitions: Vec<Vec<RecordBatch>>) ->
Result<Self> {
for batches in partitions.iter().flatten() {
let batches_schema = batches.schema();
+ println!(
+ "the new schema is {:?}, schema set is {:?}",
+ batches_schema, schema
+ );
Review Comment:
```suggestion
```
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1245,6 +1268,7 @@ pub(crate) fn validate_unique_names<'a>(
Ok(())
},
Some((existing_position, existing_expr)) => {
+ //println!("node_name is {}, existing expr is {:?}",
node_name, existing_expr);
Review Comment:
```suggestion
```
##########
datafusion/expr/src/logical_plan/builder.rs:
##########
@@ -1184,13 +1204,15 @@ pub fn build_join_schema(
right_fields.clone()
}
};
+ //println!("total fields is {:?}", fields);
Review Comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
