nealrichardson commented on a change in pull request #9367:
URL: https://github.com/apache/arrow/pull/9367#discussion_r567267561
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -854,13 +854,6 @@ else()
set(THRIFT_REQUIRES_BOOST FALSE)
endif()
-# Parquet requires boost only with gcc 4.8 (because of missing std::regex).
-if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU" AND CMAKE_CXX_COMPILER_VERSION
VERSION_LESS "4.9")
- set(PARQUET_REQUIRES_BOOST TRUE)
-else()
- set(PARQUET_REQUIRES_BOOST FALSE)
-endif()
-
Review comment:
Should also remove the lines with `BOOST_REGEX_LIBRARY` below, right?
Nothing else uses boost::regex in our code.
We can also remove regex.hpp from cpp/build-support/trim-boost.sh and
rebuild our trimmed bundle without it. That should probably be a followup JIRA,
but could you edit the comment on L38 of that script to say that we actually
don't need it anymore?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
