Dandandan opened a new pull request #9374: URL: https://github.com/apache/arrow/pull/9374
This adds year support to the temporal module. Year support is something needed for some TCPH queries. Together with `extract` support https://github.com/apache/arrow/pull/9359 we should be able to add `EXTRACT (YEAR FROM dt)` support to DataFusion. Other changes in the PR: * Adding some more tests to `hour` * Removing datatype check from inner loop (there is still one more check in `value_as_datetime` and `value_as_time`) but I leave that for a future PR, as well as further performance improvements (e.g. avoiding the `Int32Builder`, avoiding null checks, adding some microbenchmarks etc.). * Returning an error message on unsupported datatypes (instead of returning `None`). This is backwards incompatible, but I think this is reasonable. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
