tustvold commented on code in PR #5383:
URL: https://github.com/apache/arrow-rs/pull/5383#discussion_r1486916976
##########
object_store/src/client/retry.rs:
##########
@@ -263,7 +262,7 @@ impl RetryExt for reqwest::RequestBuilder {
do_retry = true
} else if let Some(source) = e.source() {
if let Some(e) =
source.downcast_ref::<hyper::Error>() {
- if e.is_connect() || e.is_closed() ||
e.is_incomplete_message() {
+ if !(e.is_parse() || e.is_parse_status() ||
e.is_parse_too_large() || e.is_user() || e.is_canceled()) {
Review Comment:
That's only if your request actually gets to S3 and you trip then trip its
limits, if you flood the network, e.g. by creating hundreds of TCP connections
to handle hundreds of concurrent HTTP/1.1 requests, there are various
components in the network that may just start dropping these connections on the
floor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
