pmcgleenon commented on code in PR #9204:
URL: https://github.com/apache/arrow-datafusion/pull/9204#discussion_r1486923060
##########
benchmarks/bench.sh:
##########
@@ -288,7 +288,7 @@ data_tpch() {
else
echo " Copying answers to ${TPCH_DIR}/answers"
mkdir -p "${TPCH_DIR}/answers"
- docker run -v "${TPCH_DIR}":/data -it --entrypoint /bin/bash --rm
ghcr.io/databloom-ai/tpch-docker:main -c "cp -f
/opt/tpch/2.18.0_rc2/dbgen/answers/* /data/answers/"
+ docker run -v "${TPCH_DIR}":/data -it --entrypoint /bin/bash --rm
ghcr.io/scalytics/tpch-docker:main -c "cp -f
/opt/tpch/2.18.0_rc2/dbgen/answers/* /data/answers/"
Review Comment:
Seems that the `dbgen` binary in the container is being used to generate the
tbl files. `dbgen` looks like C code [built with
gcc](https://github.com/scalytics/TPCH-Docker/blob/main/data/tpch/2.18.0_rc2/dbgen/makefile#L175)
so I think it would be good to avoid introducing that toolchain into this repo
That container image looks pretty niche though, so there's a risk it might
disappear or move again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
