alamb commented on code in PR #9216:
URL: https://github.com/apache/arrow-datafusion/pull/9216#discussion_r1488020260
##########
datafusion/sql/tests/sql_integration.rs:
##########
@@ -2671,13 +2673,62 @@ fn logical_plan_with_dialect_and_options(
dialect: &dyn Dialect,
options: ParserOptions,
) -> Result<LogicalPlan> {
- let context = MockContextProvider::default();
+ let context = MockContextProvider::default().with_udf(make_udf(
+ "nullif",
+ vec![DataType::Int32, DataType::Int32],
+ DataType::Int32,
+ ));
+
let planner = SqlToRel::new_with_options(&context, options);
let result = DFParser::parse_sql_with_dialect(sql, dialect);
let mut ast = result?;
planner.statement_to_plan(ast.pop_front().unwrap())
}
+fn make_udf(name: &'static str, args: Vec<DataType>, return_type: DataType) ->
ScalarUDF {
Review Comment:
The sql integration test needs function definitions, to resolve function
names, but doesn't actually invoke them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
