viirya commented on code in PR #9208:
URL: https://github.com/apache/arrow-datafusion/pull/9208#discussion_r1488104887
##########
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs:
##########
@@ -657,7 +664,7 @@ mod tests {
use datafusion_expr::{col, lit};
// test row group predicate with an unknown (Null) expr
//
- // int > 1 and bool = NULL => c1_max > 1 and null
+ // c1 > 15 and c2 = NULL => c1_max > 15 and null
Review Comment:
nit (but as take this chance to change it):
```suggestion
// c1 > 15 and c2 = NULL => c1_max > 15 and NULL
```
##########
datafusion/core/src/datasource/physical_plan/parquet/row_groups.rs:
##########
@@ -620,13 +620,20 @@ mod tests {
ParquetStatistics::boolean(Some(false), Some(true), None, 1,
false),
],
);
- vec![rgm1, rgm2]
+ let rgm3 = get_row_group_meta_data(
+ &schema_descr,
+ vec![
+ ParquetStatistics::int32(Some(17), Some(30), None, 1, false),
+ ParquetStatistics::boolean(Some(false), Some(true), None, 0,
false),
+ ],
+ );
+ vec![rgm1, rgm2, rgm3]
}
#[test]
fn row_group_pruning_predicate_null_expr() {
use datafusion_expr::{col, lit};
- // int > 1 and IsNull(bool) => c1_max > 1 and bool_null_count > 0
+ // c1 > 15 and IsNull(c2) => c1_max > 15 and c2_null_count > 0
Review Comment:
👍 This reads more smoothly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
