viirya commented on code in PR #40043:
URL: https://github.com/apache/arrow/pull/40043#discussion_r1488543823


##########
java/vector/src/main/java/org/apache/arrow/vector/BaseLargeVariableWidthVector.java:
##########
@@ -336,6 +336,35 @@ public List<ArrowBuf> getFieldBuffers() {
     return result;
   }
 
+  /**
+   * Get the buffers for exporting this vector through C Data Interface.
+   * @return the buffers ready for exporting.
+   */
+  @Override
+  public List<ArrowBuf> getCDataBuffers() {

Review Comment:
   Maybe I should add a test for this? Especially for the arrays with custom 
implementation. 🤔 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to