viirya commented on code in PR #5398:
URL: https://github.com/apache/arrow-rs/pull/5398#discussion_r1488476246
##########
arrow-cast/src/parse.rs:
##########
@@ -438,7 +438,7 @@ macro_rules! parser_primitive {
($t:ty) => {
impl Parser for $t {
fn parse(string: &str) -> Option<Self::Native> {
- lexical_core::parse::<Self::Native>(string.as_bytes()).ok()
+ string.parse::<Self::Native>().ok()
Review Comment:
Not sure if floating parser also has same issue. I'm not sure about floating
type overflow behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
