alamb commented on code in PR #9222:
URL: https://github.com/apache/arrow-datafusion/pull/9222#discussion_r1488592522
##########
datafusion/sql/src/expr/value.rs:
##########
@@ -142,10 +141,16 @@ impl<'a, S: ContextProvider> SqlToRel<'a, S> {
})
.collect::<Result<Vec<_>>>()?;
- Ok(Expr::ScalarFunction(ScalarFunction::new(
- BuiltinScalarFunction::MakeArray,
- values,
- )))
+ let make_array = self
Review Comment:
This is interesting -- now the SQL planner needs to replace the array
literals with a scalar function, but it does the lookup by name. Rather than
having this string hard coded maybe there should be a list of such functions
somewhere 🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
