lidavidm commented on code in PR #40043:
URL: https://github.com/apache/arrow/pull/40043#discussion_r1488754898
##########
java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java:
##########
@@ -476,11 +507,12 @@ private void allocateBytes(final long valueBufferSize,
final int valueCount) {
}
/* allocate offset buffer */
- private void allocateOffsetBuffer(final long size) {
+ private ArrowBuf allocateOffsetBuffer(final long size) {
Review Comment:
Since the original implementation passed tests, it's possible I've missed
something and something else is decrementing the refcount. But I'm not going to
approve this PR until either that is clearly explained, and it is clearly
explained why the shared/static placeholder buffer isn't an option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
