manoj-inukolunu commented on issue #9140:
URL: 
https://github.com/apache/arrow-datafusion/issues/9140#issuecomment-1943744754

   Thank you @alamb  , I will add a comment. I attempted to do the in list 
simplifier in one pass . I am not really sure if its possible in a single pass. 
Here is the test which is failing if i try that . 
   ```
   // c1 IN (1,2,3,4,5,6) AND c1 IN (1,3,5,6) AND c1 IN (3,6) -> c1 = 3 OR c1 = 
6
   ```
   After the first pass it simplifies to 
   ```
   c1 IN (3,6)
   ```
   After the `ShortenInListSimplifier` it simplifies to 
   ```
    c1 = 3 OR c1 = 6
    ```
    If i try to combile the `ShortenInListSimplifier` with the 
`InListSimplifier`  , in the first pass itself 
    ```
    c1 IN (3,6)
    ```
    is getting simplified to ` c1 = 3 OR c1 = 6` according to the 
`ShortenInListSimplifier` which is breaking the test . Additionaly i attempted 
a benchmark , the additional pass seems to be adding around 6% overhead. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to