alamb commented on code in PR #9220:
URL: https://github.com/apache/arrow-datafusion/pull/9220#discussion_r1489538477


##########
datafusion/core/src/datasource/statistics.rs:
##########
@@ -35,6 +35,7 @@ pub async fn get_statistics_with_limit(
     all_files: impl Stream<Item = Result<(PartitionedFile, Statistics)>>,
     file_schema: SchemaRef,
     limit: Option<usize>,
+    collect_stats: bool,

Review Comment:
   Given the function is called 'get_statistics` and now there is a boolean 
flag that implies the stats aren't collected, can we please add some 
documentation to the docstring explaining what the `collect_stats` flag does?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to