jayzhan211 commented on code in PR #9234:
URL: https://github.com/apache/arrow-datafusion/pull/9234#discussion_r1490554114
##########
datafusion/physical-expr/src/aggregate/array_agg_distinct.rs:
##########
@@ -351,23 +358,16 @@ mod tests {
let l2 = ScalarValue::List(Arc::new(l2));
let l3 = ScalarValue::List(Arc::new(l3));
- // Duplicate l1 in the input array and check that it is deduped in the
output.
- let array = ScalarValue::iter_to_array(vec![l1.clone(), l2, l3,
l1]).unwrap();
-
- let expected =
- ScalarValue::List(Arc::new(
- ListArray::from_iter_primitive::<Int32Type, _,
_>(vec![Some(vec![
- Some(1),
- Some(2),
- Some(3),
- Some(4),
- Some(5),
- Some(6),
- Some(7),
- Some(8),
- Some(9),
- ])]),
- ));
+ // Duplicate l1 and l3 in the input array and check that it is deduped
in the output.
Review Comment:
This seems more correct to me. The previous flattened result is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
