alamb commented on code in PR #8985:
URL: https://github.com/apache/arrow-datafusion/pull/8985#discussion_r1491030704
##########
datafusion/expr/src/expr_schema.rs:
##########
@@ -37,19 +37,19 @@ use std::sync::Arc;
/// trait to allow expr to typable with respect to a schema
pub trait ExprSchemable {
/// given a schema, return the type of the expr
- fn get_type<S: ExprSchema>(&self, schema: &S) -> Result<DataType>;
+ fn get_type(&self, schema: &dyn ExprSchema) -> Result<DataType>;
Review Comment:
I ran
```
cargo bench --bench sql_planner
```
And the results looked good ( within the noise threshold / reported 1%
slower which I don't attribute to this change)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
