etolbakov commented on PR #983: URL: https://github.com/apache/arrow-ballista/pull/983#issuecomment-1948881841
@andygrove Could you please take a look when you have time? Two main questions that I have: 1) the naming convention for the config keys (should it be `.` or `_` separated). Please let me know if any adjustments should be made. 2) failed to find if [distributed_query.rs](https://github.com/apache/arrow-ballista/blob/333ba24d7e6dd51fb6a5312d1309c0494bd1681d/ballista/core/src/execution_plans/distributed_query.rs#L232), [executor_process.rs](https://github.com/apache/arrow-ballista/blob/333ba24d7e6dd51fb6a5312d1309c0494bd1681d/ballista/executor/src/executor_process.rs#L287), [executor_server.rs](https://github.com/apache/arrow-ballista/blob/333ba24d7e6dd51fb6a5312d1309c0494bd1681d/ballista/executor/src/executor_server.rs#L240) are using `BallistaConfig` in order to apply the same change that I did for `context.rs`. Does the scope of this PR is suppose to add config as well? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
