ZhengLin-Li commented on issue #8452: URL: https://github.com/apache/arrow-datafusion/issues/8452#issuecomment-1949489706
Hi @alamb Thanks for your follow up. I tried to add a test case in [datafusion/sql/src/parser.rs](https://github.com/ZhengLin-Li/arrow-datafusion/pull/1/files) but it turned out that the parser did not yield an error. ``` Expected parse error for 'select TIMESTAMP '2023-12-05T21:58:10.45ZZTOP'', but was successful: [Statement(Query(Query { with: None, body: Select(Select { distinct: None, top: None, projection: [UnnamedExpr(TypedString { data_type: Timestamp(None, None), value: "2023-12-05T21:58:10.45ZZTOP" })], into: None, from: [], lateral_views: [], selection: None, group_by: Expressions([]), cluster_by: [], distribute_by: [], sort_by: [], having: None, named_window: [], qualify: None }), order_by: [], limit: None, limit_by: [], offset: None, fetch: None, locks: [], for_clause: None }))] ``` See: https://github.com/ZhengLin-Li/arrow-datafusion/actions/runs/7936448427/job/21671747144?pr=1 It seems that we only check this in cli but not in parser? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
