Divyansh200102 commented on issue #31315: URL: https://github.com/apache/arrow/issues/31315#issuecomment-1951329623
> After [ARROW-12820](https://issues.apache.org/jira/browse/ARROW-12820), the `strptime` kernel still ignores the `%Z` specifier (for timezone names), and when using it, it basically ignores any string. Does this change look good to you @rok ```diff diff --git a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc index a88ce3893..7d82e6a08 100644 --- a/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc +++ b/cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc @@ -1782,7 +1782,10 @@ const FunctionDoc strptime_doc( ("For each string in `strings`, parse it as a timestamp.\n" "The timestamp unit and the expected string pattern must be given\n" "in StrptimeOptions. Null inputs emit null. If a non-null string\n" - "fails parsing, an error is returned by default."), + "fails parsing, an error is returned by default.\n" + "\n" + "**Note:** The strptime kernel currently ignores the %Z specifier (for timezone names)." + ), {"strings"}, "StrptimeOptions", /*options_required=*/true); const FunctionDoc assume_timezone_doc{ "Convert naive timestamp to timezone-aware timestamp", ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
