Lordworms commented on code in PR #9127: URL: https://github.com/apache/arrow-datafusion/pull/9127#discussion_r1493364827
########## datafusion/sqllogictest/test_files/monotonic_projection_test.slt: ########## @@ -0,0 +1,84 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at + +# http://www.apache.org/licenses/LICENSE-2.0 + +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# prepare the table +statement ok +CREATE EXTERNAL TABLE delta_encoding_required_column ( + c_customer_sk INT NOT NULL, + c_current_cdemo_sk INT NOT NULL +) +STORED AS CSV +WITH ORDER ( + c_customer_sk DESC, + c_current_cdemo_sk DESC +) +LOCATION '../../testing/data/csv/aggregate_test_100.csv'; + +# test for substitute CAST senario Review Comment: I think this is another bug since currently datafusion could not recognize the cast and it would directly eliminate the SortExec and would not fall into my logic in this PR. Should I fix this in this PR or in the coming PR? (Since maybe there are lots of logics of whether eliminate the SortExec or add SortExec) This is the test I tried on current main branch <img width="1131" alt="image" src="https://github.com/apache/arrow-datafusion/assets/48054792/adf3148b-f55e-4ab7-9618-e6204a36224f";> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
