alamb commented on issue #9203: URL: https://github.com/apache/arrow-datafusion/issues/9203#issuecomment-1951832230
> I may know why this has not been realized before, since the TableFunctionImpl is in datafusion crate and if you want to add dependencies in execution, it would cause the cycle-depend problem. When we encounter such problem, how could we do? Make TableFunctionImpl an another crate? Hope you could give some hints, thanks! @alamb Yes, that was it! Thank you @Lordworms Normally I think we would try and move `TableFunctionImpl` into another crate, as we did for `ScalarUDF` -- which is in `datafusion_expr` I think `TableFunctionImpl` isn't hard to move, but [`TableProvider`](https://docs.rs/datafusion/latest/datafusion/datasource/provider/trait.TableProvider.html) would be hard as it depends on `ExecutionPlan` which has a bunch of dependencies on the various physical expr, functions, etc. 🤔 I am not sure how best to proceed without a larger refactor to pull table provider / execution plan into some other crate... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
