alamb commented on issue #9237: URL: https://github.com/apache/arrow-datafusion/issues/9237#issuecomment-1951850821
@devinjdangelo implemented the code in https://github.com/apache/arrow-datafusion/pull/9240 In order to close this ticket we just need to add test coverage for writing partitioned parquet in `DataFrame::write_parquet` My suggestion is: 1. Move the existing tests https://github.com/apache/arrow-datafusion/blob/4d389c2590370d85bfe3af77f5243d5b40f5a222/datafusion/core/src/datasource/physical_plan/parquet/mod.rs#L2070 tests into the dataframe tests https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/dataframe/mod.rs 2. Add a new test in https://github.com/apache/arrow-datafusion/blob/main/datafusion/core/tests/dataframe/mod.rs following the same model, to verify the parquet files were written: The new test could basically do the same thing as the tests added in https://github.com/apache/arrow-datafusion/pull/9240/files#diff-b7d6c89870d082cac4ecc6de05f2ec393559327472fc4a846986f02c812f661fR34 1. write to a partitioned table 2. read back from the table to ensure all data went there 3. Read back from one of the partitions to ensure the data was actually partitioned -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
