caicancai commented on PR #9245: URL: https://github.com/apache/arrow-datafusion/pull/9245#issuecomment-1951871324
> Thank you @caicancai for adding the tests to document this feature more fully in code > > I am hoping this type of "what should `log` do in corner cases" will have a better story once we have done #8045 -- and thus if someone wants a different set of `log` function behavior they can just register a different `log` UDF so cool, I think this is a very good idea, as a single sql engine can output the corresponding result expected by the user according to the user's custom behavior, which means that we do not need to adapt the negative test of each function in any dialect, but only need to concentrate on adapting most of the common functions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
