jayzhan211 commented on code in PR #9272: URL: https://github.com/apache/arrow-datafusion/pull/9272#discussion_r1494447712
########## datafusion/sqllogictest/test_files/array.slt: ########## @@ -4287,21 +4287,27 @@ NULL [3] [4] # array_ndims scalar function #1 -query III +query error +select array_ndims(1); + +#follow PostgreSQL +query error +select + array_ndims(null); + +query I select - array_ndims(1), - array_ndims(null), array_ndims([2, 3]); ---- -0 0 1 +1 statement ok CREATE TABLE array_ndims_table AS VALUES - (1, [1, 2, 3], [[7]], [[[[[10]]]]]), - (2, [4, 5], [[8]], [[[[[10]]]]]), - (null, [6], [[9]], [[[[[10]]]]]), - (3, [6], [[9]], [[[[[10]]]]]) + ([1], [1, 2, 3], [[7]], [[[[[10]]]]]), + ([2], [4, 5], [[8]], [[[[[10]]]]]), + ([2], [6], [[9]], [[[[[10]]]]]), Review Comment: nit: I think you can remove either row 3 or 4, they are testing the same thing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
