pitrou commented on code in PR #39804:
URL: https://github.com/apache/arrow/pull/39804#discussion_r1494538027
##########
cpp/src/arrow/acero/asof_join_node_test.cc:
##########
@@ -1582,6 +1582,70 @@ TEST(AsofJoinTest, BatchSequencing) {
return TestSequencing(MakeIntegerBatches, /*num_batches=*/32,
/*batch_size=*/1);
}
+template <typename BatchesMaker>
+void TestSchemaResolution(BatchesMaker maker, int num_batches, int batch_size)
{
+ // GH-39803: The key hasher needs to resolve the types of key columns. All
other
+ // tests use int32 for all columns, but this test converts the key columns
to
+ // strngs via a projection node to test that the column is correctly
resolved
+ // to string.
Review Comment:
```suggestion
// GH-39803: The key hasher needs to resolve the types of key columns. All
other
// tests use int32 for all columns, but this test converts the key columns
to
// strings via a projection node to test that the column is correctly
resolved
// to string.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
