sunchao opened a new pull request, #50:
URL: https://github.com/apache/arrow-datafusion-comet/pull/50
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
Closes #.
## Rationale for this change
Comet currently use `jni-rs` 0.19 which is a bit out-dated. The latest
version `0.21.x` provides more improvements including updated safety, better
JVM handling, less data copying, etc. On the other hand, it also introduced
many API changes. In the long term, we should update to `0.21`+ to get
continuous improvements from `jni-rs`.
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
This PR upgrades `jni-rs` from 0.19 to 0.21. There are many API changes
between the two versions and hence many places need to be updated as well in
the repo.
Most notably, many method calls in `jni-rs` now requires a `&mut JNIEnv` as
parameter, while it used to be `&JNIEnv`.
## How are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Existing tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
