alamb commented on code in PR #9268:
URL: https://github.com/apache/arrow-datafusion/pull/9268#discussion_r1495365487
##########
Cargo.toml:
##########
@@ -77,6 +77,7 @@ sqlparser = { version = "0.43.0", features = ["visitor"] }
tempfile = "3"
thiserror = "1.0.44"
tokio = { version = "1.36", features = ["macros", "rt", "sync"] }
+unescaper = "0.1.4"
Review Comment:
I am worried about https://crates.io/crates/unescaper -- it is maintained by
a single person and the homepage doesn't work https://hack.ink/unescaper
Its license is also somewhat questionable as it appears to be based on a
previously licensed work but doesn't include the appropriate license (e.g.
https://github.com/saghm/unescape-rs/blob/master/LICENSE but the copyright
isn't preserved)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
