mustafasrepo commented on code in PR #9273:
URL: https://github.com/apache/arrow-datafusion/pull/9273#discussion_r1495386871
##########
datafusion/physical-expr/src/equivalence/properties.rs:
##########
@@ -1054,8 +1118,8 @@ impl DependencyNode {
}
}
-type DependencyMap = HashMap<PhysicalSortExpr, DependencyNode>;
-type Dependencies = HashSet<PhysicalSortExpr>;
+type DependencyMap = IndexMap<PhysicalSortExpr, DependencyNode>;
Review Comment:
Both plans generated with IndexSet and HashSet are correct. However, when we
use `HashSet` generated plan sometimes changes in different runs (although all
are valid). `IndexSet` makes sure result is same across different runs. Added a
comment to explain ratioanale.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
