advancedxy commented on code in PR #48:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/48#discussion_r1496041374
##########
.github/actions/java-test/action.yaml:
##########
@@ -27,17 +27,19 @@ runs:
- name: Cache Maven dependencies
uses: actions/cache@v4
with:
- path: ~/.m2/repository
- key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ path: |
+ ~/.m2/repository
+ /root/.m2/repository
+ key: ${{ runner.os }}-java-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
- ${{ runner.os }}-maven-
+ ${{ runner.os }}-java-maven-
Review Comment:
added `java` and `rust` to distinguish each other so that they don't
interfere
##########
.github/actions/java-test/action.yaml:
##########
@@ -27,17 +27,19 @@ runs:
- name: Cache Maven dependencies
uses: actions/cache@v4
with:
- path: ~/.m2/repository
- key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ path: |
+ ~/.m2/repository
+ /root/.m2/repository
Review Comment:
for container users, which is root.
##########
.github/actions/java-test/action.yaml:
##########
@@ -27,17 +27,19 @@ runs:
- name: Cache Maven dependencies
uses: actions/cache@v4
with:
- path: ~/.m2/repository
- key: ${{ runner.os }}-maven-${{ hashFiles('**/pom.xml') }}
+ path: |
+ ~/.m2/repository
+ /root/.m2/repository
+ key: ${{ runner.os }}-java-maven-${{ hashFiles('**/pom.xml') }}
restore-keys: |
- ${{ runner.os }}-maven-
+ ${{ runner.os }}-java-maven-
- name: Run Maven compile
shell: bash
run: |
- ./mvnw compile test-compile scalafix:scalafix -Psemanticdb
+ ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb
Review Comment:
`-B`: batch mode. Suppresses download progress bar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
