wjones127 commented on code in PR #5402:
URL: https://github.com/apache/arrow-rs/pull/5402#discussion_r1496147631


##########
object_store/src/aws/client.rs:
##########
@@ -523,7 +535,7 @@ impl S3Client {
         let part = (part_idx + 1).to_string();
 
         let response = self
-            .put_request(path, data)
+            .put_request(path, data, false)

Review Comment:
   You are right that `CreateMultipartUpload` requires the headers, but 
`UploadPart` does not accept KMS headers. I actually hit a 400 error from S3 
when I was passing them earlier. If you look at the the headers for 
[UploadPart](https://docs.aws.amazon.com/AmazonS3/latest/API/API_UploadPart.html),
 you'll notice the encryption headers it accepts are only the SSE-C ones, not 
the KMS ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to