ClifHouck commented on code in PR #40067:
URL: https://github.com/apache/arrow/pull/40067#discussion_r1496443110
##########
cpp/src/arrow/compute/kernels/scalar_cast_numeric.cc:
##########
@@ -833,9 +833,14 @@ std::vector<std::shared_ptr<CastFunction>>
GetNumericCasts() {
auto cast_half_float =
std::make_shared<CastFunction>("cast_half_float", Type::HALF_FLOAT);
AddCommonCasts(Type::HALF_FLOAT, float16(), cast_half_float.get());
+ DCHECK_OK(cast_half_float.get()->AddKernel(Type::FLOAT,
+ {InputType(Type::FLOAT)}, float16(), CastFloatingToFloating));
Review Comment:
I'm not sure I follow. I folded converting half-float to float32/64 into
`GetCastToFloating`, but I'm not sure how to integrate float32/64 to half-float
into `GetCastToFloating`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
