matthewmcnew commented on code in PR #40105:
URL: https://github.com/apache/arrow/pull/40105#discussion_r1496525604
##########
go/parquet/file/column_writer_test.go:
##########
@@ -430,7 +430,12 @@ func (p *PrimitiveWriterTestSuite)
testDictionaryFallbackEncoding(version parque
}
func (p *PrimitiveWriterTestSuite)
testDictionaryFallbackAndCompressedSize(version parquet.Version) {
- p.GenerateData(SmallSize)
+ // skip boolean as dictionary encoding is not used
+ if p.Typ.Kind() == reflect.Bool {
+ return
+ }
+
+ p.GenerateData(LargeSize)
Review Comment:
Originally, I thought it was needed to ensure that a data page was written
but, the smallsize works. Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
