mustafasrepo commented on PR #9295:
URL: 
https://github.com/apache/arrow-datafusion/pull/9295#issuecomment-1955971356

   Thanks for this PR @Lordworms. To make sure that after conversion we indeed 
produce correct result, it would be nice to have a test with data. Something 
like
   ```sql
   SELECT a, ARRAY_AGG(c ORDER BY c), ARRAY_AGG(c ORDER BY c)[1] as result
                           FROM multiple_ordered_table
                           GROUP BY a;
   ```
   where we can determine index indeed points to correct value, after 
conversion to `NTH_VALUE`. Other than this, this PR great.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to