alamb commented on PR #9276: URL: https://github.com/apache/arrow-datafusion/pull/9276#issuecomment-1956037382
> > Thanks @devinjdangelo -- I don't fully understand what problem this PR is fixing. Is this fixing wrong results? Or a panic? Or something else 🤔 > > Could you possibly add a new test (rather than modify the existing one) so it is clearer? > > Apologies for not properly documenting the issue up front. I created #9290 to document the incorrect behavior that this PR is fixing. Essentially, ListingTables enforced a particular ordering on the columns which Copy alone does not. The logic for eliminating the partition columns from the `RecordBatches` to be written to disk needed to updated now that it cannot rely on the fixed column ordering. > > I also restored the original test and added a new one instead of modifying. Thank you so much -- I am sorry for not being able to see it immediately. I struggle these days to keep up with everthing going on and don't seem to have the ability to research things as much as I would like to -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
