blink1073 commented on PR #13826: URL: https://github.com/apache/arrow/pull/13826#issuecomment-1956545907
Hi @pedrocamargo, we ended up using this [pattern](https://github.com/mongodb-labs/mongo-arrow/blob/dbd86166a75848024b5728dc1c9c4929052a04ad/bindings/python/setup.py#L134): ```python import numpy as np import pyarrow as pa # From https://arrow.apache.org/docs/python/integration/extending.html#example # The Numpy C headers are currently required ext.include_dirs.append(np.get_include()) ext.include_dirs.append(pa.get_include()) ext.libraries.extend(pa.get_libraries()) ext.library_dirs.extend(pa.get_library_dirs()) if os.name != "nt" and CREATE_LIBARROW_SYMLINKS: # On Linux and MacOS, we must run pyarrow.create_library_symlinks() # as a user with write access to the directory where pyarrow is # installed. # See https://arrow.apache.org/docs/python/integration/extending.html#building-extensions-against-pypi-wheels. pa.create_library_symlinks() if os.name == "posix": ext.extra_compile_args.append("-std=c++17") elif os.name == "nt": ext.extra_compile_args.append("/std:c++17") ``` We also don't "repair" our [wheel](https://github.com/mongodb-labs/mongo-arrow/blob/dbd86166a75848024b5728dc1c9c4929052a04ad/bindings/python/pyproject.toml#L77), other than to add appropriate tags on [Linux](https://github.com/mongodb-labs/mongo-arrow/blob/dbd86166a75848024b5728dc1c9c4929052a04ad/bindings/python/pyproject.toml#L88). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
