jayzhan211 commented on code in PR #9249:
URL: https://github.com/apache/arrow-datafusion/pull/9249#discussion_r1497552632
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -1073,6 +1075,34 @@ pub fn create_udaf(
))
}
+/// Creates a new UDAF with a specific signature, state type and return type.
Review Comment:
Do we need schema or just sort_exprs?
1. fn accumulator(&self, arg: &DataType, sort_exprs: Vec<Expr>, schema:
Option<Schema>)
##########
datafusion/expr/src/expr_fn.rs:
##########
@@ -1073,6 +1075,34 @@ pub fn create_udaf(
))
}
+/// Creates a new UDAF with a specific signature, state type and return type.
Review Comment:
Do we need schema or just sort_exprs?
1. fn accumulator(&self, arg: &DataType, sort_exprs: Vec<Expr>, schema:
`Option<Schema>`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
