jayzhan211 commented on code in PR #9304:
URL: https://github.com/apache/arrow-datafusion/pull/9304#discussion_r1497743387
##########
datafusion/physical-expr/src/planner.rs:
##########
@@ -258,34 +258,44 @@ pub fn create_physical_expr(
)))
}
- Expr::ScalarFunction(ScalarFunction { func_def, args }) => {
- let physical_args = args
- .iter()
- .map(|e| create_physical_expr(e, input_dfschema,
execution_props))
- .collect::<Result<Vec<_>>>()?;
- match func_def {
- ScalarFunctionDefinition::BuiltIn(fun) => {
- functions::create_physical_expr(
- fun,
- &physical_args,
- input_schema,
- execution_props,
- )
- }
- ScalarFunctionDefinition::UDF(fun) => {
- let return_type = fun.return_type_from_exprs(args,
input_dfschema)?;
+ Expr::ScalarFunction(ScalarFunction { func_def, args }) => match
func_def {
+ ScalarFunctionDefinition::BuiltIn(fun) => {
+ let physical_args = args
+ .iter()
+ .map(|e| create_physical_expr(e, input_dfschema,
execution_props))
+ .collect::<Result<Vec<_>>>()?;
- udf::create_physical_expr(
- fun.clone().as_ref(),
- &physical_args,
- return_type,
- )
- }
- ScalarFunctionDefinition::Name(_) => {
- internal_err!("Function `Expr` with name should be
resolved.")
- }
+ functions::create_physical_expr(
+ fun,
+ &physical_args,
+ input_schema,
+ execution_props,
+ )
}
- }
+ ScalarFunctionDefinition::UDF(fun) => {
+ let args = match fun.simplify(args.to_owned())? {
Review Comment:
only add `simplify` here (physical plan)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
