Dandandan commented on code in PR #9236:
URL: https://github.com/apache/arrow-datafusion/pull/9236#discussion_r1497839250


##########
datafusion/core/src/physical_optimizer/enforce_distribution.rs:
##########
@@ -295,6 +296,8 @@ fn adjust_input_keys_ordering(
                         new_conditions.0,
                         filter.clone(),
                         join_type,
+                        // TODO: although projection is not used in the join 
here, because project pushdow is the last rule. Maybe we need to handle it 
later. Same as filter.

Review Comment:
   ```suggestion
                           // TODO: although projection is not used in the join 
here, because projection pushdown is the last rule. Maybe we need to handle it 
later. Same as filter.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to