yyy1000 commented on PR #9297: URL: https://github.com/apache/arrow-datafusion/pull/9297#issuecomment-1958599070
> > `select acos()` will panic, but I think it should be checked at a higher level, before the implementation of `acos`. > > Huge thanks for catching it! > > Just realized `isnan()` also has this issue, cc @alamb: > > ```shell > $ ./target/debug/datafusion-cli > DataFusion CLI v36.0.0 > ❯ select isnan(); > thread 'main' panicked at /home/steve/Documents/workspace/GitHub/arrow-datafusion/datafusion/functions/src/math/nans.rs:67:39: > index out of bounds: the len is 0 but the index is 0 > ``` > > And cc @yyy1000, `abs()` also suffers from this. > > > but I think it should be checked at a higher level, before the implementation of acos. > > Yeah, we should do it before invoking the function Yeah, thanks for telling me @SteveLauC I added the logic just now. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
