mapleFU commented on code in PR #39995:
URL: https://github.com/apache/arrow/pull/39995#discussion_r1498723434
##########
cpp/src/arrow/dataset/dataset_writer_test.cc:
##########
@@ -198,9 +198,7 @@ class DatasetWriterTestFixture : public testing::Test {
int num_batches = 0;
AssertBatchesEqual(*MakeBatch(expected_file.start,
expected_file.num_rows),
*ReadAsBatch(written_file->data, &num_batches));
- if (check_num_record_batches) {
Review Comment:
Sure, this is added in my previous patch
https://github.com/apache/arrow/pull/38885 . Here if not passing
`check_num_record_batches = false`, the check would failed because zero-sized
batch.
In this patch, it would not be produced, so I can remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
