sunchao commented on code in PR #85:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/85#discussion_r1499902166
##########
.github/actions/java-test/action.yaml:
##########
@@ -38,9 +38,17 @@ runs:
shell: bash
run: |
echo "JAVA_VERSION=${JAVA_VERSION}"
- ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb
-Djava.version=${JAVA_VERSION}
+ if [ $JAVA_VERSION == "1.8" ]; then
+ ./mvnw -B compile test-compile scalafix:scalafix -Psemanticdb
-Djava.version=${JAVA_VERSION} -Dspotless.version=2.29.0
Review Comment:
I mean whether we'll run into the issue mentioned in the PR description if
we use 2.29 for Java 8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
