advancedxy commented on code in PR #88:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/88#discussion_r1500151289
##########
spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala:
##########
@@ -320,6 +320,20 @@ class CometSparkSessionExtensions
c
}
+ case s: TakeOrderedAndProjectExec
+ if isCometNative(s.child) && isCometOperatorEnabled(conf,
"takeOrderedAndProjectExec")
+ && isCometShuffleEnabled(conf) &&
+ CometTakeOrderedAndProjectExec.isSupported(s.projectList,
s.sortOrder, s.child) =>
+ // TODO: support offset for Spark 3.4
Review Comment:
Yes. That's a minimal fix. However if we can access `offset`, we can
implement the offset logic in comet as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
