lidavidm commented on code in PR #1561:
URL: https://github.com/apache/arrow-adbc/pull/1561#discussion_r1501184209
##########
c/driver/snowflake/snowflake_test.cc:
##########
@@ -192,6 +223,72 @@ class SnowflakeStatementTest : public ::testing::Test,
void TestSqlIngestColumnEscaping() { GTEST_SKIP(); }
+ public:
+ static void SetUpTestCase() {
+ struct AdbcError error;
+ struct AdbcDatabase db;
+ struct AdbcConnection connection;
+ struct AdbcStatement statement;
+
+ std::memset(&error, 0, sizeof(error));
+ std::memset(&db, 0, sizeof(db));
+ std::memset(&connection, 0, sizeof(connection));
+ std::memset(&statement, 0, sizeof(statement));
+
+ AdbcDatabaseNew(&db, &error);
Review Comment:
We should probably be checking errors? `ASSERT_THAT(DatabaseNew(), IsOk());`
##########
c/driver/snowflake/snowflake_test.cc:
##########
@@ -35,6 +36,26 @@ using adbc_validation::IsOkStatus;
} \
} while (false)
+namespace {
+std::string get_uuid() {
Review Comment:
nit: stick to naming convention ("GetUuid")
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
