tustvold commented on code in PR #5423:
URL: https://github.com/apache/arrow-rs/pull/5423#discussion_r1501310961
##########
arrow-ord/src/cmp.rs:
##########
@@ -198,7 +198,43 @@ fn compare_op(op: Op, lhs: &dyn Datum, rhs: &dyn Datum) ->
Result<BooleanArray,
let r = r_v.map(|x| x.values().as_ref()).unwrap_or(r);
let r_t = r.data_type();
- if l_t != r_t || l_t.is_nested() {
+ if l_t != r_t {
+ return Err(ArrowError::InvalidArgumentError(format!(
+ "Invalid comparison operation: {l_t} {op} {r_t}"
+ )));
+ }
+
+ if let Struct(_) = l_t {
+ let l = l.as_struct();
+ let r = r.as_struct();
+ assert_eq!(l.num_columns(), r.num_columns());
+
+ #[allow(clippy::manual_try_fold)]
+ match op {
+ Op::Equal => {
+ return (0..l.num_columns()).fold(
+ Ok(BooleanArray::new(BooleanBuffer::new_set(len), None)),
+ |res, i| {
+ let res = res?;
+ let col_l = l.column(i);
+ let col_r = r.column(i);
+ let eq_rows = compare_op(op, col_l, col_r)?;
+
+ let nulls = NullBuffer::union(res.nulls(),
eq_rows.nulls());
+ let vals = res.values() & eq_rows.values();
+ Ok(BooleanArray::new(vals, nulls))
+ },
+ )
Review Comment:
```suggestion
return (0..l.num_columns()).try_fold(
BooleanArray::new(BooleanBuffer::new_set(len), None),
|res, i| {
let col_l = l.column(i);
let col_r = r.column(i);
let eq_rows = compare_op(op, col_l, col_r)?;
let nulls = NullBuffer::union(res.nulls(),
eq_rows.nulls());
let vals = res.values() & eq_rows.values();
Ok(BooleanArray::new(vals, nulls))
},
)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
