DDtKey commented on PR #9318:
URL: 
https://github.com/apache/arrow-datafusion/pull/9318#issuecomment-1962205925

   But a load of places were already refactored here 
https://github.com/apache/arrow-datafusion/pull/6750 🤔
   
   We have a clippy warning and can specify to use SpawnedTask in case they 
would try to use `tokio::spawn` (see `clippy.toml`)
   I guess it may improve dev experience
   
   `AbortOnDrop::spawn` can work only for `AbortOnDropSingle` and it's kinda 
confusing naming to me
   
   Every month `datafusion` has releases with breaking changes for users of 
library. Is that such important not to change internal structures which affects 
only devs? It has good outcomes at least for a product


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to