viirya commented on code in PR #99:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/99#discussion_r1501666102
##########
spark/src/test/scala/org/apache/spark/sql/CometTPCDSQuerySuite.scala:
##########
@@ -26,7 +26,8 @@ import org.apache.comet.CometConf
class CometTPCDSQuerySuite
extends {
// This is private in `TPCDSBase`.
- val excludedTpcdsQueries: Seq[String] = Seq("q34", "q64")
+ val excludedTpcdsQueries: Seq[String] =
+ Seq("q34", "q66", "q64", "q71", "q88", "q90", "q96")
Review Comment:
For example:
```
- q96 *** FAILED ***
java.lang.Exception: Expected "[0]", but got "[888]" Result did not match
```
##########
spark/src/test/scala/org/apache/spark/sql/CometTPCDSQuerySuite.scala:
##########
@@ -26,7 +26,8 @@ import org.apache.comet.CometConf
class CometTPCDSQuerySuite
extends {
// This is private in `TPCDSBase`.
- val excludedTpcdsQueries: Seq[String] = Seq("q34", "q64")
+ val excludedTpcdsQueries: Seq[String] =
+ Seq("q34", "q66", "q64", "q71", "q88", "q90", "q96")
Review Comment:
```
- q90 *** FAILED ***
java.lang.Exception: Expected "[NULL]", but got "[0.58933333333333333333]"
Result did not match
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
