viirya commented on code in PR #106:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/106#discussion_r1501675404
##########
core/src/execution/datafusion/shuffle_writer.rs:
##########
@@ -315,6 +315,9 @@ fn slot_size(len: usize, data_type: &DataType) -> usize {
// TODO: this is not accurate, but should be good enough for now
slot_size(len, key_type.as_ref()) + slot_size(len / 10,
value_type.as_ref())
}
+ // TODO: this is not accurate, but should be good enough for now
+ DataType::Binary => len * 100 + len * 4,
+ DataType::LargeBinary => len * 100 + len * 8,
Review Comment:
Oh, I missed binary type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
