tustvold commented on issue #5426: URL: https://github.com/apache/arrow-rs/issues/5426#issuecomment-1962795400
> How do we determine the final single Compare based on them without null_first? You return the appropriate variant for the case, e.g. `Compare::LeftNull`, `Compare::RightNull` or `Compare::BothNull` > It seems to be more memory efficient to have the null_first info in the first place, so we can evaluate the actual ordering early The problem is that for comparison operations we don't establish an ordering for NULLS, but instead have special logic to handle nulls based on the operator being used. Unfortunately I realise this formulation won't work for `DISTINCT` and so we may need something else :thinking: Perhaps we just need to implement a dyn dispatch version of compare_op, not sure. I'll continue to have a play time permitting -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
