viirya commented on code in PR #109:
URL:
https://github.com/apache/arrow-datafusion-comet/pull/109#discussion_r1501756369
##########
spark/src/test/scala/org/apache/comet/exec/CometColumnarShuffleSuite.scala:
##########
@@ -837,18 +759,13 @@ abstract class CometShuffleSuiteBase extends
CometTestBase with AdaptiveSparkPla
test("fix: Native Unsafe decimal accessors return incorrect results") {
Seq(10, 201).foreach { numPartitions =>
- withSQLConf(
- CometConf.COMET_EXEC_ENABLED.key -> "true",
- CometConf.COMET_COLUMNAR_SHUFFLE_ENABLED.key -> "true",
- CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true") {
Review Comment:
Hmm, these configs are used to produce a specific situation. If they are
changed, you won't fail the test but maybe it just tests nothing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
